Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fix post type check in isEditingTemplate selector #59105

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Editor: Fix post type check in isEditingTemplate selector #59105

merged 1 commit into from
Feb 26, 2024

Conversation

mattgrshaw
Copy link
Contributor

What?

This PR fixes what seems to be an invalid check in isEditingTemplate that was causing it to return true, even when not editing a template.

Why?

ACF was using this selector to check if a template was currently being edited instead of a standard post. It looks like this has been deprecated, but in WP 6.5-beta1 it seems to always return true, which could cause issues for plugins that haven't updated their code.

How?

isEditingTemplate now checks for the wp_template post type instead of post-only.

Testing Instructions

  1. In the current 6.5 beta, check the output of the isEditorTemplate selector in a standard post or page. It seems to always return true.
  2. Repeat the same on this branch, noting that it now returns false, but still returns true when editing a template (via the sidebar -> Post -> Template dropdown -> Create new template)

Screenshots or screencast

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mattgrshaw <mattshaw@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 15, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mattgrshaw! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added [Type] Regression Related to a regression in the latest release [Package] Edit Post /packages/edit-post labels Feb 16, 2024
youknowriad
youknowriad approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry, my mistake here.

@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 19, 2024
@lgladdy lgladdy mentioned this pull request Feb 26, 2024
Closed
@annezazu annezazu merged commit 705d77c into WordPress:trunk Feb 26, 2024
63 of 64 checks passed
@annezazu
Copy link
Contributor

Seeing approvals for this PR and that it's ready to squash and merge. Proceeded with doing so in order to get into 6.5!

@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 26, 2024
getdave pushed a commit that referenced this pull request Feb 27, 2024
@mattgrshaw @getdave
Updates isEditingTemplate to check for wp_template post type instea…
8646cd1 
…d of `post-only` (#59105)
@getdave
Copy link
Contributor

getdave commented Feb 27, 2024

I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 8646cd1

@getdave getdave added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 27, 2024
@getdave getdave mentioned this pull request Feb 27, 2024
Merged
9 tasks
getdave pushed a commit that referenced this pull request Feb 27, 2024
@mattgrshaw @getdave
Updates isEditingTemplate to check for wp_template post type instea…
d768dbd 
…d of `post-only` (#59105)
@mattgrshaw mattgrshaw mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Edit Post /packages/edit-post [Type] Regression Related to a regression in the latest release
Projects
No open projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
Gutenberg 17.9
Development

Successfully merging this pull request may close these issues.
5 participants
@mattgrshaw @annezazu @getdave @youknowriad @Mamaduka